Set unstable feed field - #1629
Merged
Merged
Conversation
emmambd
reviewed
Aug 21, 2026
emmambd
left a comment
emmambd
left a comment
Contributor
There was a problem hiding this comment.
Looks great! The main cases I've called out are:
- False positives where it looks like a date has been identified where it doesn't exist
- Feeds that have versions. I don't -think- we should treat these as unstable because versions could theoretically last for years, but I'm open to discussion on it
| @@ -19,5 +19,6 @@ | |||
| "direct_download": "https://transport-data-gouv-fr-resource-history-prod.cellar-c2.services.clever-cloud.com/79752/79752.20231005.100848.400086.zip", | |||
Contributor
There was a problem hiding this comment.
Looks good - just noticing these France feeds could be redirected to TDG alternatives in many cases. Could be a separate issue
Contributor
Author
There was a problem hiding this comment.
Will create a separate issue searching for redirects for these french feeds
emmambd
approved these changes
Aug 25, 2026
emmambd
left a comment
emmambd
left a comment
Contributor
There was a problem hiding this comment.
This LGTM now with the changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Rule Set
csv detailing updated feeds after rules were removed:
unstable_producer_urls.csv